feat: add renovate #1

aladdin-add · 2025-06-30T15:11:12Z

base.json5 is applicable to all projects.
eslint-base.json5 extends base.json5 and adds ESLint related configurations.

fixes: #13

nzakas · 2025-07-02T15:29:05Z

Given that there's nothing in the repo yet, maybe we should wait before activating Renovate for this repo? We don't really know what we need to update yet.

aladdin-add · 2025-07-02T16:50:18Z

Based on my understanding, renovate should be activated to repositories using this configuration file (e.g. eslint/eslint, which has been enabled), rather than this repository itself. For easier maintenance, we could enable it across the entire eslint org. Alternatively, we might choose to enable it selectively only for repositories that actually require it.

nzakas · 2025-07-02T18:47:42Z

Yes, this is how renovate is setup for repositories, but as I said, this repository doesn't have any dependencies. It doesn't make sense to set up renovate until we know what we want it to update. There's no way to know that right now.

aladdin-add · 2025-07-02T19:48:10Z

It's not clear to me. the file is just mean to be used by other repos, as you can see here: eslint/eslint#19907

nzakas · 2025-07-03T20:30:55Z

Oh I see, you're intending to share this configuration across repos. I think we should hold off on this for now because I'm not sure what we'd consider common for all the repos.

lumirlumir · 2025-07-10T13:51:16Z

Oh I see, you're intending to share this configuration across repos. I think we should hold off on this for now because I'm not sure what we'd consider common for all the repos.

I think starting with common GitHub Actions workflows or Renovate config setups would be a good approach for this repository.

When reviewing some of the issues I suggested earlier (such as the ones below), these workflows and logics seem to be commonly used across ESLint repositories:

On a related note, there are currently three repositories that serve to maintain centralized workflows or templates:

Clarifying the scope of these repositories and consolidating common logic into these three centralized repositories could help make maintaining the ESLint project easier.

(Just as a personal opinion, I think clarifying the scope is important. For example, eslint-github-bot could potentially take on some of the responsibilities of the workflows repository, since it is capable of handling tasks similar to what GitHub Actions can do.)

Also, I think enabling Renovate or Dependabot across repositories would be helpful, since it would automate updates and allow us to quickly catch any potential incompatibilities with new versions.

nzakas · 2025-07-10T15:20:15Z

I think starting with common GitHub Actions workflows or Renovate config setups would be a good approach for this repository.

I agree. What I'm saying is that we haven't decided on what common Renovate settings we want across repos, so I think it would be better to open an issue to discuss that before making a pull request.

Similarly, I think we should look across repos to see what are the most common GitHub action workflows we have and start by adding those to this repo before we look at creating things that don't necessarily exist already.

lumirlumir · 2025-07-17T14:30:35Z

Ah, I got it! 😄

I've been interested in this topic for a while, so I'll go ahead and open an issue about it first.

lumirlumir · 2025-07-28T09:36:29Z

I've finished writing an issue here: #4

lumirlumir · 2025-08-02T09:22:26Z

Hi, @aladdin-add 😄

There has been some progress on this issue, along with discussions about how the team would like to move forward:

#4 (comment)

I think we're ready to proceed with this PR. If you have a chance, it would be great if you could take a look.

nzakas · 2025-08-04T14:44:45Z

I'd like to see a concrete proposal for what settings make sense for all repos.

lumirlumir · 2025-08-05T13:18:02Z

If @aladdin-add doesn’t have time, and if he’s okay with it, I’d be happy to take a look after the add-to-triage and stale workflows have been adopted.

aladdin-add · 2025-08-05T17:17:15Z

I'm sorry, I've been recovering from an illness recently and have very limited time to devote to open-source projects. But I'll try to get this done within 1-2 weeks. If you have time to help, I'd be happy to have your assistance.

1. base.json5 is applicable to all projects 2. eslint-base.json5 extends base.json5 and adds ESLint related configurations

aladdin-add · 2025-08-28T16:39:30Z

.github/renovate/eslint-base.json5

+      description: "Update ESLint packages together.",
+      groupName: "eslint",
+      matchPackagePrefixes: ["@eslint/"],
+      matchPackageNames: ["espree", "eslint-scope", "eslint-visitor-keys"],


not adding eslint, eslint-config-eslint - they usually belong to dev-dependencies.

pushed a new commit to group eslint & eslint-config-eslint: 360397d

nzakas · 2025-08-29T14:21:50Z

.github/renovate/eslint-base.json5

@@ -0,0 +1,19 @@
+{
+  $schema: "https://docs.renovatebot.com/renovate-schema.json",
+  extends: ["github>eslint/workflows//.github/renovate/base.json5"],


Can we just use a local file path instead?

Suggested change

extends: ["github>eslint/workflows//.github/renovate/base.json5"],

extends: ["base.json5"],

not sure if it can work as expected - it may be seen as built-in preset. I will change it to ./base.json5 to see if it's working.

FYI, I've also looked at the official documentation, but it seems there's no way to use a local path directly. 🤔

https://docs.renovatebot.com/config-presets/#github

lumirlumir

Thanks! This looks good to me on my end. 👍

Would like @nzakas to verify before merging.

Small suggestion: if possible, could we add a final newline to each file? Since EditorConfig is set up to enforce a final newline, it would be nice to include them.

workflows/.editorconfig

Line 9 in c069e25

insert_final_newline = true

lumirlumir · 2025-08-30T11:03:38Z

.github/renovate/eslint-base.json5

@@ -0,0 +1,19 @@
+{
+  $schema: "https://docs.renovatebot.com/renovate-schema.json",
+  extends: ["github>eslint/workflows//.github/renovate/base.json5"],


FYI, I've also looked at the official documentation, but it seems there's no way to use a local path directly. 🤔

https://docs.renovatebot.com/config-presets/#github

lumirlumir

Re-approving.

eslint-github-bot bot added the feature label Jun 30, 2025

aladdin-add mentioned this pull request Jun 30, 2025

Implementing a centralized repository for our GitHub Actions configurations eslint/eslint#17856

Closed

1 task

aladdin-add marked this pull request as ready for review July 1, 2025 15:01

lumirlumir added this to Triage Jul 1, 2025

github-project-automation bot moved this to Needs Triage in Triage Jul 1, 2025

lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 1, 2025

aladdin-add mentioned this pull request Jul 1, 2025

ci: simplify renovate configuration eslint/eslint#19907

Draft

1 task

nzakas moved this from Needs Triage to Triaging in Triage Jul 2, 2025

aladdin-add moved this from Triaging to Implementing in Triage Jul 9, 2025

aladdin-add force-pushed the feat/renovate branch from e295914 to 08b61e9 Compare August 28, 2025 16:31

feat: add renovate configs

8f9e81a

1. base.json5 is applicable to all projects 2. eslint-base.json5 extends base.json5 and adds ESLint related configurations

aladdin-add force-pushed the feat/renovate branch from 08b61e9 to 8f9e81a Compare August 28, 2025 16:33

aladdin-add commented Aug 28, 2025

View reviewed changes

feat: add ESLint dev dependencies update group

360397d

nzakas reviewed Aug 29, 2025

View reviewed changes

lumirlumir previously approved these changes Aug 30, 2025

View reviewed changes

fix: add eol at end of json5 files

dd6918f

aladdin-add dismissed lumirlumir’s stale review via dd6918f August 31, 2025 02:45

lumirlumir approved these changes Aug 31, 2025

View reviewed changes

	extends: ["github>eslint/workflows//.github/renovate/base.json5"],
	extends: ["base.json5"],

Uh oh!

feat: add renovate #1

Are you sure you want to change the base?

feat: add renovate #1

Conversation

aladdin-add commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nzakas commented Jul 2, 2025

Uh oh!

aladdin-add commented Jul 2, 2025

Uh oh!

nzakas commented Jul 2, 2025

Uh oh!

aladdin-add commented Jul 2, 2025

Uh oh!

nzakas commented Jul 3, 2025

Uh oh!

lumirlumir commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nzakas commented Jul 10, 2025

Uh oh!

lumirlumir commented Jul 17, 2025

Uh oh!

lumirlumir commented Jul 28, 2025

Uh oh!

lumirlumir commented Aug 2, 2025

Uh oh!

nzakas commented Aug 4, 2025

Uh oh!

lumirlumir commented Aug 5, 2025

Uh oh!

aladdin-add commented Aug 5, 2025

Uh oh!

aladdin-add Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

aladdin-add Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

nzakas Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

aladdin-add Aug 30, 2025

Choose a reason for hiding this comment

Uh oh!

lumirlumir Aug 30, 2025

Choose a reason for hiding this comment

Uh oh!

lumirlumir left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lumirlumir Aug 30, 2025

Choose a reason for hiding this comment

Uh oh!

lumirlumir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aladdin-add commented Jun 30, 2025 •

edited

Loading

lumirlumir commented Jul 10, 2025 •

edited

Loading

lumirlumir left a comment •

edited

Loading