Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add 2023-06-29 meeting notes #439

Merged
merged 2 commits into from
Jul 10, 2023
Merged

docs: Add 2023-06-29 meeting notes #439

merged 2 commits into from
Jul 10, 2023

Conversation

sam3k
Copy link
Contributor

@sam3k sam3k commented Jun 30, 2023

Closes #437

- [ ] `typescript-eslint` PR opened; waiting for Nx to get updated to use flat config
- [ ] `eslint-config-standard` PR opened
- [ ] `eslint-plugin-vue` PR opened
- [ ] `eslint-plugin-react` PR to be submitted by @mdjermanovic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-plugin-react has added its support in v7.32.0:
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md#added-1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-plugin-react started exporting flat configs in v7.32.0 but they are not using flat config in the repo. That's what @mdjermanovic is going to send a PR for

nzakas
nzakas previously approved these changes Jun 30, 2023
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one point of clarification.

- [ ] `typescript-eslint` PR opened; waiting for Nx to get updated to use flat config
- [ ] `eslint-config-standard` PR opened
- [ ] `eslint-plugin-vue` PR opened
- [ ] `eslint-plugin-react` PR to be submitted by @mdjermanovic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-plugin-react started exporting flat configs in v7.32.0 but they are not using flat config in the repo. That's what @mdjermanovic is going to send a PR for

notes/2023/2023-06-29.md Outdated Show resolved Hide resolved
mdjermanovic
mdjermanovic previously approved these changes Jul 8, 2023
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending #439 (comment)

@nzakas nzakas dismissed stale reviews from mdjermanovic and themself via 53f9166 July 10, 2023 15:21
@nzakas nzakas merged commit 969e44a into eslint:main Jul 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSC meeting 29-June-2023
4 participants