refactor: simplify no-bare-urls with ESQuery selector
#511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-simplify-no-bare-urls-with-esquery-selector
lumirlumir
commented
Aug 26, 2025
src/util.js
Outdated
There was a problem hiding this comment.
I’ve just added some markers to clarify which category each util belongs to.
tests/rules/no-bare-urls.test.js
Outdated
There was a problem hiding this comment.
I've added additional test cases to more thoroughly verify the changes before and after.
I've confirmed that these tests pass in the previous codebase.
nzakas
reviewed
Aug 26, 2025
nzakas
reviewed
Aug 27, 2025
|
I've added a new commit c5e2bfa |
nzakas
deleted the
refactor-simplify-no-bare-urls-with-esquery-selector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Hi,
In this PR, I've simplified
no-bare-urlsrule with ESQuery selector. This is follow-up to #495 and #498.The code has been updated a bit to maintain the same behavior without re-traversing the AST with a
forloop.The main point of the previous logic was that URLs between HTML tags were not reported.
I've tried to keep the logic as close as possible, except that it now uses ESQuery selectors.
I also aimed to make the code cleaner and minimize the use of variables.
There may still be room for improvement, so I’d be happy to hear any suggestions!
What changes did you make? (Give an overview)
In this PR, I've simplified
no-bare-urlsrule with ESQuery selector. This is follow-up to #495 and #498.Related Issues
Refs: #495, #498
Is there anything you'd like reviewers to focus on?