fix: false negative on shortcut type ref in no-missing-label-refs
#406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Which language are you using?
CommonMark and GFM.
What did you do?
I've used
*foo*
,**foo**
,~~foo~~
,~~**foo**~~
,~~***foo***~~
, and similar formats for the definition. Based on this, I expected patterns like the ones below to be reported as missing label references, but some were not detected.What did you expect to happen?
According to the AST, patterns like
*foo*
,**foo**
,~~foo~~
,~~**foo**~~
, and~~***foo***~~
can be recognized as valid label references:So, I expected the following patterns to be reported by this rule:
Link to minimal reproducible Example
What changes did you make? (Give an overview)
The current implementation only checks the
Text
node when detecting missing label reference syntax.However, this causes an issue when
Strong
,Emphasis
, orDelete
markers (represented by*
,_
, or~
) are used in the syntax.With these markers, a label like
[**foo**]
will have itsText
node split into[
,foo
, and]
as shown in the AST below, making it impossible to detect the missing label reference pattern.Related Issues
N/A
Is there anything you'd like reviewers to focus on?