refactor: switch to eslint v9, eslint-config-eslint v10 #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
commented
Apr 30, 2024
Comment on lines
-27
to
-30
| "n/no-unsupported-features/es-syntax": ["error", { | ||
| version: ">=16.0.0", | ||
| ignores: ["modules"] | ||
| }] |
There was a problem hiding this comment.
This override is apparently no longer needed with the latest version of eslint-plugin-n.
aladdin-add
approved these changes
Apr 30, 2024
mdjermanovic
commented
Apr 30, 2024
| @@ -160,7 +157,7 @@ export const Syntax = (function() { | |||
| } | |||
|
|
|||
| for (key in VisitorKeys) { | |||
| if (Object.hasOwnProperty.call(VisitorKeys, key)) { | |||
| if (Object.hasOwn(VisitorKeys, key)) { | |||
There was a problem hiding this comment.
This was reported by prefer-object-has-own.
mdjermanovic
commented
Apr 30, 2024
| @@ -27,7 +27,7 @@ const SUPPORTED_VERSIONS = [ | |||
| * @returns {number} The latest ECMAScript version. | |||
| */ | |||
| export function getLatestEcmaVersion() { | |||
| return SUPPORTED_VERSIONS[SUPPORTED_VERSIONS.length - 1]; | |||
| return SUPPORTED_VERSIONS.at(-1); | |||
There was a problem hiding this comment.
This was reported by unicorn/prefer-at.
mdjermanovic
commented
Apr 30, 2024
| "lint": "eslint . --report-unused-disable-directives", | ||
| "lint": "eslint .", |
There was a problem hiding this comment.
--report-unused-disable-directives CLI flag is no longer needed because it is set to "error" in the config.
mdjermanovic
commented
Apr 30, 2024
Comment on lines
-73
to
80
| let result = tester.getExpectedResult(code, { | ||
| const result = tester.getExpectedResult(code, { | ||
| loc: true, | ||
| range: true, | ||
| tokens: true | ||
| }); | ||
|
|
||
| JSON.stringify(result).to(testResultFilename); | ||
| result = null; | ||
| }); |
There was a problem hiding this comment.
This was reported by no-useless-assignment.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using eslint v9 and eslint-config-eslint v10 to lint this project.
Marked as
refactoras it has changes in the production code.