Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Set default schema: [], drop support for function-style rules #139

Merged
merged 6 commits into from
Dec 26, 2023
Merged

feat!: Set default schema: [], drop support for function-style rules #139

merged 6 commits into from
Dec 26, 2023

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic marked this pull request as draft November 29, 2023 12:33
@mdjermanovic mdjermanovic mentioned this pull request Nov 30, 2023
Merged
1 task
@mdjermanovic
Copy link
Member Author

This is ready for review.

nzakas
nzakas approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The explicit error messaging is a nice touch. 👍

@mdjermanovic mdjermanovic mentioned this pull request Dec 21, 2023
Closed
1 task
@mdjermanovic mdjermanovic marked this pull request as ready for review December 26, 2023 21:34
@mdjermanovic mdjermanovic merged commit a6c240d into main Dec 26, 2023
15 checks passed
@mdjermanovic mdjermanovic deleted the eslint-issue14709 branch December 26, 2023 21:35
@github-actions github-actions bot mentioned this pull request Dec 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
breaking feature
Projects
Triage
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdjermanovic @nzakas