fix: improve message for ignored files without a matching config #18404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cli
✅ Deploy Preview for docs-eslint canceled.
|
fasttime
commented
Apr 29, 2024
| @@ -70,7 +70,7 @@ | |||
| "@eslint-community/regexpp": "^4.6.1", | |||
| "@eslint/eslintrc": "^3.0.2", | |||
| "@eslint/js": "9.1.1", | |||
| "@humanwhocodes/config-array": "^0.13.0", | |||
| "@humanwhocodes/config-array": "github:humanwhocodes/config-array#pull/138/head", | |||
There was a problem hiding this comment.
To be updated with a new version specifier.
1 task
lib/eslint/eslint-helpers.js
Outdated
| message = "File ignored because of a matching ignore pattern. Use \"--no-ignore\" to disable file ignore settings or use \"--no-warn-ignored\" to suppress this warning."; | ||
| } else { | ||
| message = "File ignored because no matching configration was supplied."; |
There was a problem hiding this comment.
Suggested change
| message = "File ignored because no matching configration was supplied."; | |
| message = "File ignored because no matching configuration was supplied."; |
Typo.
There was a problem hiding this comment.
Fixed in d15c087, thanks.
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
Still working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #18263
What changes did you make? (Give an overview)
Extended
createIgnoreResultwith an additional parameter that indicates whether a file has a matching configuration, in order to provide a better message when this is not the case. The value passed with this parameter is retrieved directly fromConfigArray, which got a new methodisFileConfiguredfor this purpose. See the PR inconfig-array: humanwhocodes/config-array#138.Is there anything you'd like reviewers to focus on?