chore: remove eslintrc export from eslint-config-eslint #18400
Merged
+468
−478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
|
I'm not sure why |
1 task
aladdin-add
previously approved these changes
Apr 26, 2024
aladdin-add
reviewed
Apr 26, 2024
| "rollup-plugin-node-polyfills", | ||
|
|
||
| // FIXME: not sure why is eslint-config-eslint reported as unused | ||
| "eslint-config-eslint" |
There was a problem hiding this comment.
it can be fixed by putting eslint.config.js in the entry.
and L35~38 can also be removed. :)
There was a problem hiding this comment.
it can be fixed by putting
eslint.config.jsin the entry.
I tried that first, in 9f0f9b6, but it didn't work. Not sure why.
https://github.com/eslint/eslint/actions/runs/8845405029/job/24289216911
There was a problem hiding this comment.
and L35~38 can also be removed. :)
Done in f67403a
aladdin-add
added
the
accepted
nzakas
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
LGTM. Would like @aladdin-add to verify his changes before merging.
|
@mdjermanovic it has been merged, ready to release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Removes eslintrc export from eslint-config-eslint so that we can publish v10 without it.
What changes did you make? (Give an overview)
packages/eslint-config-eslint/eslintrc.jsdirectly into the root.eslintrc.js.packages/eslint-config-eslint/eslintrc.jsfile and the corresponding export frompackages/eslint-config-eslint/package.json..eslintrc.js.Is there anything you'd like reviewers to focus on?