Breaking: RuleTester Improvements (refs eslint/rfcs#25) #12955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Add something to the core
refs eslint/rfcs#25
Additional validations in the RuleTester.
What changes did you make? (Give an overview)
This PR implements 1.-3. from eslint/rfcs#25
.start
and.end
properties. Test that happens to trigger such code is supposed to fail.output
property will fail if the rule has fixed the code.errors
is a number.The remaining improvement from the rfc (4. fail on unknown error properties) is in PR #12096.
Is there anything you'd like reviewers to focus on?
node.start
andnode.end
. This PR also includestoken.start
andtoken.end
(and the same for comment tokens), is it okay?"Use comment.range[0] instead of comment.start"
(as it is implemented now), or"Use token.range[0] instead of token.start"
.tests/lib/rules/spaced-comment.js
are removed, since it's no longer possible to test parsing errors.tests/lib/rules/_set-default-parser.js
file. If I understand this correctly, that file is no longer needed.