Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alerts action bar #702

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

xbinaryx
Copy link

@xbinaryx xbinaryx commented Mar 7, 2025

Prerequisites checklist

What is the purpose of this pull request?

Implemented a new AlertsActionBar component.

What changes did you make? (Give an overview)

This pull request adds a new persistent bar to the top of the console, providing "Fix All" and "Disable All" buttons. "Fix All" resolves all fixable errors, while "Disable All" disables all error rules.

Related Issues

Closes #549

Is there anything you'd like reviewers to focus on?

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bf7546b
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/67d06302e0724a0008bd648d
😎 Deploy Preview https://deploy-preview-702--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit bf7546b
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/67d06302d4aeb50008f85516
😎 Deploy Preview https://deploy-preview-702--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit bf7546b
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/67d063021f517300080e18d3
😎 Deploy Preview https://deploy-preview-702--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit bf7546b
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/67d06302f741c9000824bd6b
😎 Deploy Preview https://deploy-preview-702--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit bf7546b
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/67d06302bdab7e0008a8133e
😎 Deploy Preview https://deploy-preview-702--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit bf7546b
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/67d06302e062170009ee9f2b
😎 Deploy Preview https://deploy-preview-702--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit bf7546b
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/67d06302e0724a0008bd6492
😎 Deploy Preview https://deploy-preview-702--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit bf7546b
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/67d063027233be0008ea75ec
😎 Deploy Preview https://deploy-preview-702--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xbinaryx, thanks for the PR,

Right now the new fixable button still appears even there are non-fixable issues
see this
can you make it appear only when there are fixable issues?

Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable button disables the rule from right sidebar and appears only when rule is included in right sidebar rules list can we do the same for disable all button.

Screenshot 2025-03-08 202227

Screenshot 2025-03-08 202305

and also i feel both buttons (Fix All and Disable All ) should appear when there are more than one issue to fix or to disable?

@xbinaryx
Copy link
Author

xbinaryx commented Mar 8, 2025

Disable button disables the rule from right sidebar and appears only when rule is included in right sidebar rules list can we do the same for disable all button.

Ah yeah my bad. This should be fixed now.

and also i feel both buttons (Fix All and Disable All ) should appear when there are more than one issue to fix or to disable?

I opted to hide the whole bar instead of just the buttons. What do you think?

Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-11 at 18-41-23 ESLint Playground - ESLint - Pluggable JavaScript Linter

One more thing rules that are giving suggestions instead of fixes don't have a disable button in their alert can we replicate that in new button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Triaging
Development

Successfully merging this pull request may close these issues.

Suggestion: [playground]add a button fix all will fix all problems which can be fixed.
2 participants