Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add code explorer in the navbar #682

Merged
merged 2 commits into from
Mar 10, 2025
Merged

feat: add code explorer in the navbar #682

merged 2 commits into from
Mar 10, 2025

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Add code explorer in the navbar

What changes did you make? (Give an overview)

Fixes #676

Related Issues

Is there anything you'd like reviewers to focus on?

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit ad903b0
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/67cd42e1e690ab0008304dbd
😎 Deploy Preview https://deploy-preview-682--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit ad903b0
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/67cd42e169b4660008966555
😎 Deploy Preview https://deploy-preview-682--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit ad903b0
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/67cd42e18b098500083a58dd
😎 Deploy Preview https://deploy-preview-682--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit ad903b0
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/67cd42e1234e4e00085b895c
😎 Deploy Preview https://deploy-preview-682--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit ad903b0
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/67cd42e17da28800086a6c10
😎 Deploy Preview https://deploy-preview-682--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit ad903b0
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/67cd42e18b098500083a58df
😎 Deploy Preview https://deploy-preview-682--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit ad903b0
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/67cd42e1d955f400085a6374
😎 Deploy Preview https://deploy-preview-682--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit ad903b0
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/67cd42e1b3a03e000813b350
😎 Deploy Preview https://deploy-preview-682--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tanujkanti4441 Tanujkanti4441 mentioned this pull request Dec 28, 2024
Merged
1 task
Tanujkanti4441
Tanujkanti4441 reviewed Dec 28, 2024
View reviewed changes
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most of the language versions, navbar is collapsing the ESLint logo:
In spanish
Screenshot 2024-12-28 132509
In japanese
Screenshot 2024-12-28 132927
In French
Screenshot 2024-12-28 133106

and in Portuguese, and German also

should we make the dropdown navbar appear in 1023px as in docs?

@amareshsm
Copy link
Member Author

In most of the language versions, navbar is collapsing the ESLint logo: In spanish Screenshot 2024-12-28 132509 In japanese Screenshot 2024-12-28 132927 In French Screenshot 2024-12-28 133106

and in Portuguese, and German also

should we make the dropdown navbar appear in 1023px as in docs?

yes, I will change it accordingly.

@xbinaryx
Copy link

xbinaryx commented Mar 8, 2025

Hey @amareshsm, are you still actively working on this? If you're no longer able to continue, I'd be happy to take over and see it through.

@amareshsm
Copy link
Member Author

amareshsm commented Mar 9, 2025 •
edited
Loading

Hey @amareshsm, are you still actively working on this? If you're no longer able to continue, I'd be happy to take over and see it through.

Hey, I think its already done.

Edit: I got it I forgot to push the change. Thanks.

@amareshsm amareshsm requested a review from Tanujkanti4441 March 9, 2025 07:31
Tanujkanti4441
Tanujkanti4441 approved these changes Mar 9, 2025
View reviewed changes
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nzakas
Copy link
Member

nzakas commented Mar 10, 2025

@Tanujkanti4441 just a reminder: if you approve a PR and don't merge it, please leave a comment explaining why.

@Tanujkanti4441
Copy link
Contributor

@Tanujkanti4441 just a reminder: if you approve a PR and don't merge it, please leave a comment explaining why.

Sure! just wanted another approval here.

nzakas
nzakas approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit d268ad9 into main Mar 10, 2025
37 checks passed
@nzakas nzakas deleted the add-explorer-link branch March 10, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

@Tanujkanti4441 Tanujkanti4441 Tanujkanti4441 approved these changes

Assignees
No one assigned
Labels
accepted feature translation
Projects
Triage
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Add code explorer link to the nav bar
4 participants
@amareshsm @xbinaryx @nzakas @Tanujkanti4441