New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add thanks.dev #655

Merged

nzakas merged 5 commits into main from chore/add-thanksdev

Oct 29, 2024

Member

harish-sethuraman commented Oct 25, 2024

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

closes #653

What changes did you make? (Give an overview)

added thanks.dev donors inside sponsors
modified the return type. Its not an array instead its a promise with object and its values

Related Issues

Suggestion: Include thanks.dev sponsors #653

Is there anything you'd like reviewers to focus on?

just confirm if we want this to be inside sponsors or donations


          chore: add thanks.dev

14828d0

eslint-github-bot bot added the chore label

netlify bot commented Oct 25, 2024 •

edited

Loading

✅ Deploy Preview for new-eslint ready!

Name	Link
🔨 Latest commit	`b22e6ca`
🔍 Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/67212b936c68e80008dd35e2
😎 Deploy Preview	https://deploy-preview-655--new-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 25, 2024 •

edited

Loading

✅ Deploy Preview for es-eslint ready!

Name	Link
🔨 Latest commit	`b22e6ca`
🔍 Latest deploy log	https://app.netlify.com/sites/es-eslint/deploys/67212b9395990b0008aa5473
😎 Deploy Preview	https://deploy-preview-655--es-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 25, 2024 •

edited

Loading

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`b22e6ca`
🔍 Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/67212b9318d32200082679e9
😎 Deploy Preview	https://deploy-preview-655--ja-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 25, 2024 •

edited

Loading

✅ Deploy Preview for zh-hans-eslint ready!

Name	Link
🔨 Latest commit	`b22e6ca`
🔍 Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/67212b93dbdacf0008b37062
😎 Deploy Preview	https://deploy-preview-655--zh-hans-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 25, 2024 •

edited

Loading

✅ Deploy Preview for hi-eslint ready!

Name	Link
🔨 Latest commit	`b22e6ca`
🔍 Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/67212b93ca64f4000863b1b4
😎 Deploy Preview	https://deploy-preview-655--hi-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 25, 2024 •

edited

Loading

✅ Deploy Preview for fr-eslint ready!

Name	Link
🔨 Latest commit	`b22e6ca`
🔍 Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/67212b93b8bce4000811d539
😎 Deploy Preview	https://deploy-preview-655--fr-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 25, 2024 •

edited

Loading

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`b22e6ca`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/67212b93b98eed00087e0cdd
😎 Deploy Preview	https://deploy-preview-655--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 25, 2024 •

edited

Loading

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`b22e6ca`
🔍 Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/67212b93a919b200086282de
😎 Deploy Preview	https://deploy-preview-655--de-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amareshsm added the accepted label

Member

amareshsm commented Oct 25, 2024

just confirm if we want this to be inside sponsors or donations

Since we can't distinguish between donations and sponsors from the data in the thanks.dev API, it seems we should treat these as donations.

amareshsm reviewed

View reviewed changes

tools/fetch-sponsors.js Show resolved Hide resolved

Member Author

harish-sethuraman commented Oct 25, 2024 •

edited

Loading

Since we can't distinguish between donations and sponsors from the data in the thanks.dev API, it seems we should treat these as donations.

the issue says we need to add the users to sponsors can you confirm once @nzakas. Seems like I missed to push the latter commit will push.


          chore: add thanksdev to sponsors

8ad6180

nzakas reviewed

View reviewed changes

Member

nzakas left a comment

Thanks for taking a look at this. I left a couple notes on the algorithm.

And yes, we want these folks to end up in the sponsors list.

tools/fetch-sponsors.js Outdated Show resolved Hide resolved

tools/fetch-sponsors.js Outdated Show resolved Hide resolved


          chore: review changes

be4874c

nzakas reviewed

View reviewed changes

tools/fetch-sponsors.js Outdated Show resolved Hide resolved

tools/fetch-sponsors.js Outdated Show resolved Hide resolved


          chore: review changes

279ef97

nzakas reviewed

View reviewed changes

tools/fetch-sponsors.js Show resolved Hide resolved


          chore: add total donations

b22e6ca

nzakas approved these changes

View reviewed changes

Member

nzakas left a comment

LGTM. Thanks!

nzakas merged commit f8fee43 into main

37 checks passed

nzakas deleted the chore/add-thanksdev branch

October 29, 2024 20:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels