Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update custom rules v9 upgrade post #560

Merged
merged 4 commits into from Apr 25, 2024
Merged

fix: Update custom rules v9 upgrade post #560

merged 4 commits into from Apr 25, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Apr 25, 2024

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Updated the post about upgrading rules for v9 to ensure the code works without error.

To do so, I moved some content around to ensure all of the examples built on earlier examples

Related Issues

Fixes #559

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Apr 25, 2024
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 00c38ad
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/662a9fec3b47a30008b5f742
😎 Deploy Preview https://deploy-preview-560--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 00c38ad
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/662a9fec53140a0008313c78
😎 Deploy Preview https://deploy-preview-560--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 00c38ad
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/662a9fec6b1f640008c4876e
😎 Deploy Preview https://deploy-preview-560--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 00c38ad
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/662a9fec2dfe020008b35c60
😎 Deploy Preview https://deploy-preview-560--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 00c38ad
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/662a9fec6172cf0009550593
😎 Deploy Preview https://deploy-preview-560--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 00c38ad
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/662a9fec326c000008b065ba
😎 Deploy Preview https://deploy-preview-560--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 00c38ad
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/662a9feceea99e0008946122
😎 Deploy Preview https://deploy-preview-560--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 00c38ad
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/662a9feceab84f0008ca6692
😎 Deploy Preview https://deploy-preview-560--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I've tested all examples with eslint v8.0.0 and eslint v9.1.1.

@mdjermanovic mdjermanovic merged commit 0a866d9 into main Apr 25, 2024
37 checks passed
@mdjermanovic mdjermanovic deleted the blog-updates branch April 25, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Docs: context migration suggestions fail on earlier v8 versions
2 participants