fix: correctly guard "Fix All" when no fixable messages#1004
Open
fix: correctly guard "Fix All" when no fixable messages#1004
Conversation
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DMartens
reviewed
Apr 16, 2026
| @@ -252,7 +252,7 @@ const App = () => { | |||
|
|
|||
| const onFixAll = () => { | |||
| const hasFixableMessages = messages.filter(message => message.fix); | |||
Contributor
There was a problem hiding this comment.
As this is a boolish context, I think we rather should use .some instead of .filter (and not use the .length property).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
Fixes a logic bug in the playground's "Fix All" action so it correctly detects when there are no auto-fixable ESLint messages and returns early. Previously the guard was ineffective, causing an unnecessary call to
linter.verifyAndFix()on every click even when nothing was fixable.What changes did you make? (Give an overview)
Updated app.jsx: replaced the truthiness check on the filtered array with a length check:
Before
After:
Related Issues
Is there anything you'd like reviewers to focus on?