chore: switch to eslint flat config #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
commented
Aug 30, 2023
lib/index.js
Outdated
| @@ -24,6 +24,8 @@ function filterKey(key) { | |||
| return !KEY_BLACKLIST.has(key) && key[0] !== "_"; | |||
| } | |||
|
|
|||
|
|
|||
| /* eslint-disable jsdoc/valid-types -- doesn't allow `readonly`. TODO: check why */ | |||
There was a problem hiding this comment.
For some reason, readonly string[] is considered invalid by jsdoc/valid-types. I disabled the rule here until we figure out what's the problem because changing this type would affect the types this package publishes.
There was a problem hiding this comment.
Maybe worth opening an issue on the plugin?
There was a problem hiding this comment.
Good idea. The issue template suggested opening an issue on the parser, here it is:
There was a problem hiding this comment.
It seems like jsdoc-type-pratt-parser/jsdoc-type-pratt-parser#164 won't be fixed anytime soon since there's still no response.
mdjermanovic
commented
Aug 30, 2023
lib/visitor-keys.js
Outdated
| @@ -1,6 +1,8 @@ | |||
| /* eslint-disable jsdoc/valid-types -- doesn't allow `readonly`. TODO: check why */ | |||
There was a problem hiding this comment.
This is also reported in jsdoc-type-pratt-parser/jsdoc-type-pratt-parser#164
mdjermanovic
force-pushed
the
flat-eslint
branch
from
d4c7bba
to
cdd19cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to flat config for linting this project.