refactor: exclude keys if not leading to an object with a non-comment…

… type

lib/index.js

@@ -12,17 +12,20 @@ import KEYS from "./visitor-keys.js";
 const KEY_BLACKLIST = new Set([
  "parent",
 
+ // "type",
+ // "range",
+
  // SourceLocation
- "loc",
+ // "loc",
 
  // Comment
- "comments",
- "innerComments",
+ // "comments",
+ // "innerComments",
  "leadingComments",
- "trailingComments",
+ "trailingComments"
 
  // *Operator
- "operator"
+ // "operator"
 ]);
 
 /**

tests/lib/fixtures/bad-type-value.d.ts

@@ -0,0 +1,8 @@
+interface BadExpression {
+ type: undefined;
+}
+
+export interface NewFangledExpression {
+ type: "NewFangledExpression";
+ right: BadExpression;
+}

tests/lib/fixtures/new-keys-on-old-order-switched.d.ts

@@ -1,3 +1,14 @@
+export type AssignmentOperator = "=";
+interface Pattern {
+ type: "Pattern"
+};
+interface MemberExpression {
+ type: "MemberExpression"
+};
+interface Expression {
+ type: "Expression"
+};
+
 export interface AssignmentExpression {
  type: "AssignmentExpression";
  operator: AssignmentOperator;

tests/lib/fixtures/new-keys-on-old-other-order.d.ts

@@ -1,3 +1,14 @@
+export type AssignmentOperator = "=";
+interface Pattern {
+ type: "Pattern"
+};
+interface MemberExpression {
+ type: "MemberExpression"
+};
+interface Expression {
+ type: "Expression"
+};
+
 export interface AssignmentExpression {
  type: "AssignmentExpression";
  operator: AssignmentOperator;

tests/lib/fixtures/new-keys-on-old.d.ts

@@ -1,5 +1,31 @@
+export type AssignmentOperator = "=";
+
+interface IgnoreBase {
+ type: "Line";
+}
+
+type AnotherIgnore = IgnoreBase;
+
+interface BasePattern {
+ type: "Pattern"
+};
+interface IgnoreChild extends Omit<BasePattern, "type"> {
+};
+
+interface Pattern {
+ type: "Pattern"
+};
+interface MemberExpression {
+ type: "MemberExpression"
+};
+interface Expression {
+ type: "Expression"
+};
+
 export interface AssignmentExpression {
  type: "AssignmentExpression";
+ ignore: IgnoreChild;
+ anotherIgnore: AnotherIgnore;
  operator: AssignmentOperator;
  up: Expression;
  down: Expression;

tests/lib/fixtures/new-keys.d.ts

@@ -1,3 +1,14 @@
+export type AssignmentOperator = "=";
+interface Pattern {
+ type: "Pattern"
+};
+interface MemberExpression {
+ type: "MemberExpression"
+};
+interface Expression {
+ type: "Expression"
+};
+
 export interface NewFangledExpression {
  type: "NewFangledExpression";
  operator: AssignmentOperator;

tests/lib/get-keys-from-ts.js

@@ -184,4 +184,18 @@ describe("getKeysFromTsFile", () => {
 
  expect(error.message).to.equal("Type unknown as to traversability: BadExpression");
  });
+
+ it("throws with bad type value", async () => {
+ let error;
+
+ try {
+ await getKeysFromTsFile(
+ "./tests/lib/fixtures/bad-type-value.d.ts"
+ );
+ } catch (err) {
+ error = err;
+ }
+
+ expect(error.message).to.equal("Unexpected `type` value property type TSUndefinedKeyword");
+ });
 });