fix: use eslint v9 when choosing react

fixes #106

lib/config-generator.js

@@ -28,7 +28,7 @@ export class ConfigGenerator {
  this.packageJsonPath = options.packageJsonPath || findPackageJson(this.cwd);
  this.answers = options.answers || {};
  this.result = {
- devDependencies: [],
+ devDependencies: ["eslint@^9.2.0"],
  configFilename: "eslint.config.js",
  configContent: ""
  };
@@ -67,7 +67,7 @@ export class ConfigGenerator {
  message: "Which framework does your project use?",
  initial: 0,
  choices: [
- { message: "React", name: "react" },
+ { message: "React (eslint v8 is required to ensure compatibility with eslint-plugin-react)", name: "react" },
  { message: "Vue.js", name: "vue" },
  { message: "None of these", name: "none" }
  ]
@@ -166,9 +166,10 @@ const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: plug
  }
 
  if (this.answers.framework === "react") {
- this.result.devDependencies.push("eslint-plugin-react");
+ this.result.devDependencies.push("eslint-plugin-react", "@eslint/compat");
  importContent += "import pluginReactConfig from \"eslint-plugin-react/configs/recommended.js\";\n";
- exportContent += " pluginReactConfig,\n";
+ importContent += "import { fixupConfigRules } from \"@eslint/compat\";\n";
+ exportContent += " ...fixupConfigRules(pluginReactConfig),\n";
  }
  if (this.answers.config) {
  const config = this.answers.config;
@@ -179,7 +180,19 @@ const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: plug
  const peers = fetchPeerDependencies(config.packageName);
 
  if (peers !== null) {
- this.result.devDependencies.push(...peers);
+ const eslintIndex = peers.findIndex(dep => (dep.startsWith("eslint@")));
+
+ if (eslintIndex === -1) {
+ // eslint is not in the peer dependencies
+
+ this.result.devDependencies.push(...peers);
+ } else {
+
+ // eslint is in the peer dependencies => overwrite eslint version
+ this.result.devDependencies[0] = peers[eslintIndex];
+ peers.splice(eslintIndex, 1);
+ this.result.devDependencies.push(...peers);
+ }
  }
 
  if (config.type === "flat" || config.type === void 0) {
@@ -198,11 +211,6 @@ const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: plug
  this.result.devDependencies.push("@eslint/eslintrc", "@eslint/js");
  }
 
- const hasEslint = this.result.devDependencies.some(dep => (/^eslint(@|$)/u.test(dep)));
-
- if (!hasEslint) {
- this.result.devDependencies.push("eslint");
- }
  this.result.configContent = `${importContent}
 ${needCompatHelper ? helperContent : ""}
 export default [\n${exportContent}];`;

tests/__snapshots__/config@eslint-config-airbnb

@@ -15,8 +15,8 @@ export default [
 ];",
  "configFilename": "eslint.config.mjs",
  "devDependencies": [
- "eslint-config-airbnb",
  "eslint@^7.32.0 || ^8.2.0",
+ "eslint-config-airbnb",
  "eslint-plugin-import@^2.25.3",
  "eslint-plugin-jsx-a11y@^6.5.1",
  "eslint-plugin-react@^7.28.0",

tests/__snapshots__/config@eslint-config-airbnb-base

@@ -15,8 +15,8 @@ export default [
 ];",
  "configFilename": "eslint.config.mjs",
  "devDependencies": [
- "eslint-config-airbnb-base",
  "eslint@^7.32.0 || ^8.2.0",
+ "eslint-config-airbnb-base",
  "eslint-plugin-import@^2.25.2",
  "@eslint/eslintrc",
  "@eslint/js",

tests/__snapshots__/config@eslint-config-standard

@@ -15,8 +15,8 @@ export default [
 ];",
  "configFilename": "eslint.config.mjs",
  "devDependencies": [
- "eslint-config-standard",
  "eslint@^8.0.1",
+ "eslint-config-standard",
  "eslint-plugin-import@^2.25.2",
  "eslint-plugin-n@^15.0.0 || ^16.0.0 ",
  "eslint-plugin-promise@^6.0.0",

tests/__snapshots__/config@eslint-config-standard-flat

@@ -7,8 +7,8 @@ export default [
 ];",
  "configFilename": "eslint.config.mjs",
  "devDependencies": [
- "eslint-config-standard",
  "eslint@^8.0.1",
+ "eslint-config-standard",
  "eslint-plugin-import@^2.25.2",
  "eslint-plugin-n@^15.0.0 || ^16.0.0 ",
  "eslint-plugin-promise@^6.0.0",

tests/__snapshots__/config@eslint-config-standard-flat2

@@ -7,8 +7,8 @@ export default [
 ];",
  "configFilename": "eslint.config.mjs",
  "devDependencies": [
- "eslint-config-standard",
  "eslint@^8.0.1",
+ "eslint-config-standard",
  "eslint-plugin-import@^2.25.2",
  "eslint-plugin-n@^15.0.0 || ^16.0.0 ",
  "eslint-plugin-promise@^6.0.0",

tests/__snapshots__/config@eslint-config-xo

@@ -15,8 +15,8 @@ export default [
 ];",
  "configFilename": "eslint.config.mjs",
  "devDependencies": [
- "eslint-config-xo",
  "eslint@>=8.56.0",
+ "eslint-config-xo",
  "@eslint/eslintrc",
  "@eslint/js",
  ],

tests/__snapshots__/problems-commonjs-none-javascript

@@ -10,8 +10,8 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
- "eslint",
  ],
 }

tests/__snapshots__/problems-commonjs-none-typescript

@@ -12,9 +12,9 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "typescript-eslint",
- "eslint",
  ],
 }

tests/__snapshots__/problems-commonjs-react-javascript

@@ -2,19 +2,21 @@
  "configContent": "import globals from "globals";
 import pluginJs from "@eslint/js";
 import pluginReactConfig from "eslint-plugin-react/configs/recommended.js";
+import { fixupConfigRules } from "@eslint/compat";
 
 
 export default [
  {files: ["**/*.js"], languageOptions: {sourceType: "commonjs"}},
  {languageOptions: { globals: {...globals.browser, ...globals.node} }},
  pluginJs.configs.recommended,
- pluginReactConfig,
+ ...fixupConfigRules(pluginReactConfig),
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "eslint-plugin-react",
- "eslint",
+ "@eslint/compat",
  ],
 }

tests/__snapshots__/problems-commonjs-react-typescript

@@ -3,21 +3,23 @@
 import pluginJs from "@eslint/js";
 import tseslint from "typescript-eslint";
 import pluginReactConfig from "eslint-plugin-react/configs/recommended.js";
+import { fixupConfigRules } from "@eslint/compat";
 
 
 export default [
  {files: ["**/*.js"], languageOptions: {sourceType: "commonjs"}},
  {languageOptions: { globals: {...globals.browser, ...globals.node} }},
  pluginJs.configs.recommended,
  ...tseslint.configs.recommended,
- pluginReactConfig,
+ ...fixupConfigRules(pluginReactConfig),
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-react",
- "eslint",
+ "@eslint/compat",
  ],
 }

tests/__snapshots__/problems-commonjs-vue-javascript

@@ -12,9 +12,9 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "eslint-plugin-vue",
- "eslint",
  ],
 }

tests/__snapshots__/problems-commonjs-vue-typescript

@@ -14,10 +14,10 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-vue",
- "eslint",
  ],
 }

tests/__snapshots__/problems-esm-none-javascript

@@ -9,8 +9,8 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
- "eslint",
  ],
 }

tests/__snapshots__/problems-esm-none-typescript

@@ -11,9 +11,9 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "typescript-eslint",
- "eslint",
  ],
 }

tests/__snapshots__/problems-esm-react-javascript

@@ -2,18 +2,20 @@
  "configContent": "import globals from "globals";
 import pluginJs from "@eslint/js";
 import pluginReactConfig from "eslint-plugin-react/configs/recommended.js";
+import { fixupConfigRules } from "@eslint/compat";
 
 
 export default [
  {languageOptions: { globals: {...globals.browser, ...globals.node} }},
  pluginJs.configs.recommended,
- pluginReactConfig,
+ ...fixupConfigRules(pluginReactConfig),
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "eslint-plugin-react",
- "eslint",
+ "@eslint/compat",
  ],
 }

tests/__snapshots__/problems-esm-react-typescript

@@ -3,20 +3,22 @@
 import pluginJs from "@eslint/js";
 import tseslint from "typescript-eslint";
 import pluginReactConfig from "eslint-plugin-react/configs/recommended.js";
+import { fixupConfigRules } from "@eslint/compat";
 
 
 export default [
  {languageOptions: { globals: {...globals.browser, ...globals.node} }},
  pluginJs.configs.recommended,
  ...tseslint.configs.recommended,
- pluginReactConfig,
+ ...fixupConfigRules(pluginReactConfig),
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-react",
- "eslint",
+ "@eslint/compat",
  ],
 }

tests/__snapshots__/problems-esm-vue-javascript

@@ -11,9 +11,9 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "eslint-plugin-vue",
- "eslint",
  ],
 }

tests/__snapshots__/problems-esm-vue-typescript

@@ -13,10 +13,10 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-vue",
- "eslint",
  ],
 }

tests/__snapshots__/problems-script-none-javascript

@@ -10,8 +10,8 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
- "eslint",
  ],
 }

tests/__snapshots__/problems-script-none-typescript

@@ -12,9 +12,9 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "typescript-eslint",
- "eslint",
  ],
 }

tests/__snapshots__/problems-script-react-javascript

@@ -2,19 +2,21 @@
  "configContent": "import globals from "globals";
 import pluginJs from "@eslint/js";
 import pluginReactConfig from "eslint-plugin-react/configs/recommended.js";
+import { fixupConfigRules } from "@eslint/compat";
 
 
 export default [
  {files: ["**/*.js"], languageOptions: {sourceType: "script"}},
  {languageOptions: { globals: {...globals.browser, ...globals.node} }},
  pluginJs.configs.recommended,
- pluginReactConfig,
+ ...fixupConfigRules(pluginReactConfig),
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "eslint-plugin-react",
- "eslint",
+ "@eslint/compat",
  ],
 }

tests/__snapshots__/problems-script-react-typescript

@@ -3,21 +3,23 @@
 import pluginJs from "@eslint/js";
 import tseslint from "typescript-eslint";
 import pluginReactConfig from "eslint-plugin-react/configs/recommended.js";
+import { fixupConfigRules } from "@eslint/compat";
 
 
 export default [
  {files: ["**/*.js"], languageOptions: {sourceType: "script"}},
  {languageOptions: { globals: {...globals.browser, ...globals.node} }},
  pluginJs.configs.recommended,
  ...tseslint.configs.recommended,
- pluginReactConfig,
+ ...fixupConfigRules(pluginReactConfig),
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
+ "eslint@^9.2.0",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-react",
- "eslint",
+ "@eslint/compat",
  ],
 }