refactor: remove unnecessary "use client" "use server" directives
#131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lumirlumir!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
lumirlumir
changed the title
"use client" and "use server" directives"use client" "use server" directives
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
amareshsm
added
the
accepted
amareshsm
deleted the
refactor-remove-unnecessary-use-client-and-use-server-directives
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've removed unnecessary
"use client"and"use server"directives.According to the official React documentation and my understanding, the
"use client"and"use server"directives only have meaning when used in the context of React Server Components.However, Code Explorer is currently a Single Page Application (SPA), and the React Server Component paradigm is not used anywhere.
Therefore, removing these directives should be safe, and I confirmed this change introduces no side effects.
Additionally, there were a warning caused by the
"use server"directive when runningnpm run build, as shown below:Since this change, the warning no longer appears.
What changes did you make? (Give an overview)
In this PR, I've removed unnecessary
"use client"and"use server"directives.Related Issues
N/A
Is there anything you'd like reviewers to focus on?
N/A