Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix it to not use context.getScope. #172

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

ota-meshi
Copy link
Member

close #171

@ota-meshi ota-meshi requested review from aladdin-add and a team December 5, 2023 10:47
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d69bc4) 96.95% compared to head (6635c7b) 96.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          13       13           
  Lines        2102     2102           
  Branches      397      397           
=======================================
  Hits         2038     2038           
  Misses         63       63           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor suggestions, otherwise LGTM.

docs/api/ast-utils.md Outdated Show resolved Hide resolved
docs/api/scope-utils.md Outdated Show resolved Hide resolved
docs/api/scope-utils.md Outdated Show resolved Hide resolved
test/test-lib/get-scope.mjs Outdated Show resolved Hide resolved
@ota-meshi ota-meshi merged commit fa2c69a into main Dec 6, 2023
16 checks passed
@ota-meshi ota-meshi deleted the eslint-v9-compat branch December 6, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preparing for eslint 9.0
2 participants