fix getSemanticScholarCount #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetch citationCount directly rather than counting the length of citations because the API wouldn't return citations totally, the later length is limited to 9998 or thereabouts.
|
I just tested the function in the Zotero JavaScript console. I didn't try the plugin after the change, so please make sure it really works in your plugin test environment. |
|
Looking forward to the new release after merge so that I can recount citations in my Zotero, thanks! |
Setting-Bunny
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch citationCount directly rather than counting the length of citations because the API wouldn't return citations totally, the later length is limited to 9998 or thereabouts.