Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated a few things #18

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

finickydesert
Copy link

fixed the grammar a bit.

I corrected the grammar a bit
Corrected the grammar on this page, I hope.
I corrected a few things on this page.
Updated the grammar
Copy link
Contributor

@garrettw garrettw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a lot of improvements here, but it's definitely not ready to be merged.

@@ -1,22 +1,22 @@
# Admin Bare Metal/VM Guide

Below is a step-by-step guide of the process for creating your own /kbin instance from the moment a new VPS/VM is created or directly on bare-metal.
This is a preliminary outline that will help you launch an instance for your own needs.
This is a preliminary outline that will help you launch an instance for your needs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"own" is not a problem here


> **Note**
> /kbin is still in the early stages of development.

If you would like to support the project, you can register using the following [affiliate link](https://hetzner.cloud/?ref=8tSPCw0qqIwl).

This guide is aimed for Debian / Ubuntu distribution servers, but it could run on any modern Linux distro. This guide will however uses the `apt` commands.
This guide is aimed for Debian / Ubuntu distribution servers, but it could run on any modern Linux distro. This guide will, however, will use the `apt` commands.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still bad; you repeated "will". Just make it "will, however, use"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, you can suggest changes on GitHub by specifying the triple-tick language to be "suggestion" and filling in your preferred version of the line like this!

Suggested change
This guide is aimed for Debian / Ubuntu distribution servers, but it could run on any modern Linux distro. This guide will, however, will use the `apt` commands.
This guide is aimed for Debian / Ubuntu distribution servers, but it could run on any modern Linux distro. This guide will, however, use the `apt` commands.

This way, they can easily implement your requests and you'll also get credited as the author of the commit.

@@ -243,15 +243,15 @@ sudo nano /etc/redis/redis.conf
# Change no to systemd, considering Ubuntu is using systemd
```

Save and exit (ctrl+x) the file.
Save and exit (CTRL+x) the file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you consider "ctrl" to be wrong, then so is "CTRL". It's not an acronym, it's the word "Control", so use what most keyboards use: "Ctrl"

@@ -264,7 +264,7 @@ REDIS_DNS=redis://${REDIS_PASSWORD}@${REDIS_HOST}

### PostgreSQL (Database)

Create new `kbin` database user, using the password, `{!SECRET!!KEY!-32_2-!}`, you generated earlier:
Create a new `kbin` database user, using the password, `{!SECRET!!KEY!-32_2-!}`, you generated earlier:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is correct, but the sentence is still awkward and needs more work.
I would suggest something like this:
Create a new kbin database user, using the password you generated earlier ({!SECRET!!KEY!-32_2-!}):

@@ -771,17 +771,17 @@ php bin/console kbin:user:admin <username>
php bin/console kbin:ap:keys:update
```

Next, log in and create a magazine named "random" to which unclassified content from the fediverse will flow.
Next, log in and create a magazine named random to which unclassified content from the Fediverse will flow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that adding smart quotes is useful or necessary.

@@ -30,7 +30,7 @@
* `post:edit`
* `post_comment:create`
* `post_comment:edit`
3. `delete` - Provides all of the following nested scopes, for deleting the current user's content
3. `delete` - Provides all the following nested scopes, for deleting the current user's content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here -- "of" does belong

@@ -153,7 +153,7 @@
* `moderate:magazine:reports:read`
* Allows the client to read reports about content from magazines the user moderates
* `moderate:magazine:reports:action`
* Allows the client to take action on reports, either accepting or rejecting them
* Allows the client to act on reports, either accepting or rejecting them
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think either version here is better than the other

@@ -8,42 +8,42 @@ The initiative aims to promote a free and open internet.
## Introduction

The platform is divided into thematic categories called magazines. By default, any user can create their own magazine
and automatically become its owner. Then they receive a number of administrative tools that will help them personalize
and automatically become its owner. Then they receive many administrative tools that will help them personalize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessarily the same meaning. "Many" implies that the number of tools is large, while "a number of" generally carries the connotation of "maybe many, but at least several"

company platform or a general instance with thousands of active users.

## User guide

### Customization

Everyone has the ability to customize the appearance to suit your preferences. In the sidebar, you'll find an options
Everyone can customize the appearance to suit their preferences. In the sidebar, you'll find an option
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"options" is more correct here, as the button's purpose is to reveal "a variety of settings". If the button used text rather than just an icon, it would more likely say "Options" rather than "Option".


So don't be afraid to experiment with the various options available in the sidebar. You might be surprised at just how
much you can change the appearance of the platform to suit your preferences.
much, you can change the appearance of the platform to suit your preferences.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 100% incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants