Fix parsing of ISO 8601 decimal fractions of a second #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is limited to milli- and microseconds interpreted as 3 or 6 places after decimal comma. All of the following, while valid according to the standard, won't be accepted: - 2001-03-10T17:16:17.1Z - 2001-03-10T17:16:17.12Z - 2001-03-10T17:16:17.1234Z - 2001-03-10T17:16:17.12345Z - 2001-03-10T17:16:17.1234567Z
|
Great. But this only accepts 3 or 6 decimal places? Not everything under 6? |
|
Ok, I didn't realize it's not that much more effort to do full support. The caveats now:
|
|
Any comments, required fixes, need for more tests? I'd be happy to see this merged, otherwise the library is missing quite a useful piece of functionality. |
|
Sorry for the delay, i think this is good now, will merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's based on top of #77 - please see the discussion there for some context. The solution here is not complete yet - any decimal fraction should be accepted, but 3 and 6 places after the comma are a good start, since milliseconds and microseconds are SI standardized submultiples of a second.