CT: disable cth_readable_failonly hook when verbose option is set #2975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The story:
ct:pal
as a convenient way of showing what's going on.rebar3 ct
-vvv
and--verbosity 99
allowed to seect:print
, but notct:pal
dbg
, and it showedct:pal
is not even calledcth_readable_failonly
stuff (parse_transform and hook)So, I think current behaviour is harmful:
cth_readable_failonly
is unavoidable in current main, making it hard to debug testsct:fail(test)
in the end) just for debugging screws things up --ct:print
andct:pal
outputs are reorderedThis PR disables
cth_readable_failonly
hook when verbose option is given by user.With this change
rebar3 ct
behaves more consistent to me:ct:print
orct:pal
(by design, I suppose)-v
option I see both (as I expect)