-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for less verbose test execution output on SKIPPED #2821
Allow for less verbose test execution output on SKIPPED #2821
Conversation
Instead of SKIPPED we get a magenta *..., if verbose is true
@ferd, did you eventually get around to this one? Cheers. |
not yet, hectic work week and busy nights, I had no bandwidth for OSS stuff this week. |
Sure, no hurry, I understand how it goes. Was just gently bumping 😄 |
hm, not seeing it apply well.
Or is it only being silent on specific skip types? |
I didn't mean to make it specific, so it's possible something's off. Is this running on Edit: it's possible I'm only picking up stuff from |
The CLI, however, takes precedence from the .config file
0631798
to
fd487a9
Compare
Pushed fd487a9 with a minor change in implementation: the CLI takes precedence over the ResultsResults are as follows. Below:
For:
we get
For:
we get
The default behavior is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this now works okay and can be merged, though we may have a subtle bug in the library when a whole suite gets skipped:
===> Running Common Test suites...
%%% cfg_SUITE: ...
%%% session_SUITE: ....
%%% dirmon_event_SUITE: ..
%%% dirmon_tracker_SUITE: ...................
%%% revault_fsm_SUITE: ...............................
%%% revault_tls_SUITE: .....
%%% s3_integration_SUITE: ************%%% boot_SUITE: .
Skipped 10 (10, 0) tests. Passed 65 tests.
we get a missing linebreak on the trailing end of the skipped element if the next one is expected to be a final point.
I think this may need to be fixed at the cth_readable level though, tricky one to see.
I don't think it should be a blocker, but I also don't know if that might mess up tools that parse rebar3 suite output
I can look at this when I have some time. Otherwise I can also try to hack something in |
yeah no problem. An option is to at least do the patching in the vendored code so we can test it more easily, I don't know if I'll have programming time set aside for OSS stuff this week yet. |
I can't seem to replicate this, though I'll keep trying. Here's an example output
The whole Ah, this might depend on "readable" vs. "compact" shell. Lemme look closer. Edit: I don't know what options you're using. 😄 |
Something seems kinda broken already with
(this is with option |
I've gotten to a point (with some control flags) where stuff in the compact shell looks like
and
but still I'd like to confirm you |
Sorry, just getting back to this this week. I was using the default Rebar3 file in the rebar3 project with the commands |
Via a couple of control flags (assuming sequential test execution) we're able to output better visuals We make use of HMod:post_end_per_testcase/5 as supported by most recent versions of Erlang 21+ This is not yet a complete change since: 1. we're doing it for demo purposes 2. we're not replicating the changes to cth_readable_shell
80c2238
to
e8428ac
Compare
Code was mostly redone as manipulation of ~n and related elements didn't suit the current requirements
e8428ac
to
fa35b88
Compare
@ferd, I'm revisiting this, but am not in a hurry to get it reviewed. I just had it in my TODO and wanted to not forget it. Current results follow. I added more variety to tests, started covering "all skipped" suites and re-worked the
where Edit: I just saw it's not finishing properly, since it's not outputting the very last |
... for last executed suite And take this time to filter out end_per_suite and init_per_suite from the test case output (when skipped)
Pushed a new fix. If this is Ok I can maybe move it to |
Closing as per ferd/cth_readable#42 (comment), which is linked to this one. |
The change
As proposed by ferd/cth_readable#41, instead of
SKIPPED
we get a magenta*
, ifverbose
istrue
.Vendoring
cth_readable
inI vendored
cth_readable
1.6.0 in by changingapps/rebar/rebar.config
to use the new version, then ranrebar3 experimental vendor
from the root folder (after removing thevendor
andvendor_plugins
folders).Not all of the vendored changes are from my previous pull request, and part of the result of command
vendor
(that which presented changes outside thecth_readable
folder) were omitted :erlware_commons
'rebar.config.script
is also updated - without changing the reference version.Default
verbose
The default
verbose
isfalse
; I wonder if the output of the tests (from e.g. stdout) is considered part of the interface.Example output after the change
Ex. (as per the current integration):
Closes #2809.