Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix external (non-rebar3) project compile #1978

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aboroska
Copy link
Contributor

Attempt to fix #1977

@ferd
Copy link
Collaborator

ferd commented Dec 15, 2018

This essentially appears to turn off validating whether the project can be built at all. So while this might fix a rabbit build, it means that you could check out a totally invalid dependency (such as a Haskell project) and we would hardly give a warning about it.

I don't think this is acceptable.

@aboroska
Copy link
Contributor Author

aboroska commented Dec 15, 2018

Yes, I agree. As I mentioned in #1977 that the check should be moved to after running the pre-hooks. I amended the PR with where the verification should be in my opinion. Left the error message as it was before.

Tested by removing the pre compile hook, so the following config:

{deps, [{rabbit_common, {git, "https://github.com/rabbitmq/rabbitmq-common.git", {ref, "9719670db30"}}}]}.

Now gives:

===> Compiling rabbit_common
===> {dep_app_not_found,<<"rabbit_common">>}

for rebar3 compile

@tsloughter
Copy link
Collaborator

I think we should probably allow for the dep to not be an OTP structured app until after pre-hooks.

One thing missing in this is a format_error function for when the dep_app_not_found error is thrown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rabbitmq_common compilation from source
3 participants