Stop starting applications when terminating node #9494
Conversation
CT Test Results 2 files 70 suites 1h 7m 42s ⏱️ For more details on these failures, see this check. Results for commit 2437d38. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
This is necessary to be able to later interact with this process
…node Applications that didn't finish starting could be left in a half-broken state during node shutdown. In particular, their dependencies would be already shut down, while the application itself was running, likely with many errors. The behaviour is to replicate what happens if the application finished starting - with timeout set, we'll respect this timeout; otherwise we'll wait forever.
michalmuskala
force-pushed
the
app-startup
branch
from
7f0ee75 to
2437d38
Compare
|
I pushed an update that skips the change removing |
|
The test failure looks unrelated. As to the header checks - similar test modules don't seem to have them. I'm not sure if there's some opt-out list or how to fix that. Advice would be appreciated. |
Applications that didn't finish starting could be left in a half-broken state during node shutdown. In particular, their dependencies would be already shut down, while the application itself was running, likely with many errors. The behaviour is to replicate what happens if the application finished starting - with timeout set, we'll respect this timeout; otherwise we'll wait forever.
This has some setup work in earlier commits, trying to make the change gradual. I recommend reviewing the commits separately.
Fixes #8485