erts: fix sub binary bug in erl_bif_re #9478
Conversation
CT Test Results 4 files 227 suites 1h 55m 25s ⏱️ Results for commit 31849d0. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
| @@ -629,6 +629,7 @@ static bool get_iolist_as_bytes(Eterm iolist, | |||
|
|
|||
| ERTS_GET_BITSTRING(iolist, *bytes_p, bit_offs, bit_sz); | |||
| if (!BIT_OFFSET(bit_offs) && !TAIL_BITS(bit_sz)) { | |||
| *bytes_p += BYTE_OFFSET(bit_offs); | |||
There was a problem hiding this comment.
Nice catch!
A testcase that tests regex as sub-binaries would be good. Maybe also test byte unaligned regex strings even if that is very unlikely to be used in practice.
Do we even have a testcase for subject strings as sub-binaries?
There was a problem hiding this comment.
Sure, added tests
frazze-jobb
added
the
testing
frazze-jobb
changed the title
lib/stdlib/test/re_SUITE.erl
Outdated
| try | ||
| nomatch = re:run(Subject, Bin2, [{capture, none}]) | ||
| catch error:badarg -> | ||
| %% *** argument 2: neither an iodata term nor a compiled regular expression | ||
| ok | ||
| end. |
There was a problem hiding this comment.
Should this be something like
ok = try ... catch error:badarg -> ok end.
to make sure it actually raised a badarg.
lib/stdlib/test/re_SUITE.erl
Outdated
| <<0:1, Subject2/binary>> = Bin2 = <<0:1,"::1">>, | ||
| match = re:run(Subject2, REC, [{capture, none}]), | ||
| match = re:run(Subject2, RE, [{capture, none}]), | ||
| try |
frazze-jobb
force-pushed
the
frazze/erts/erl_re_bif_binary_offset_bug/GH-9438/OTP-19507
branch
from
bb104d9 to
31849d0
Compare
Closes GH-9438