Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling: "hopeful" #9474

Merged
merged 1 commit into from
Feb 28, 2025
Merged

spelling: "hopeful" #9474

merged 1 commit into from
Feb 28, 2025

Conversation

adamwight
Copy link
Contributor

Cleans up a small spelling glitch. Separate commits are put in order of increasing risk, as judged by an inexperienced eye.

Copy link
Contributor

github-actions bot commented Feb 23, 2025

CT Test Results

    3 files    141 suites   50m 40s ⏱️
1 607 tests 1 557 ✅ 50 💤 0 ❌
2 325 runs  2 255 ✅ 70 💤 0 ❌

Results for commit 9a6a7e1.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@jhogberg jhogberg added the team:VM Assigned to OTP team VM label Feb 24, 2025
@bjorng bjorng added fix testing currently being tested, tag is used by OTP internal CI labels Feb 24, 2025
@bjorng
Copy link
Contributor

bjorng commented Feb 24, 2025

Thanks for your pull request. All those changes seem to be safe. I've added the branch to our daily builds.

@bjorng bjorng removed the testing currently being tested, tag is used by OTP internal CI label Feb 24, 2025
@adamwight adamwight changed the title [draft] spelling: "hopeful" spelling: "hopeful" Feb 24, 2025
@bjorng
Copy link
Contributor

bjorng commented Feb 25, 2025

It turned out that there was a merge conflict with another branch in our daily builds, so I decided to wait until that branch had been merged. It is now merged. Please rebase your branch on the latest master and resolve the conflicts.

@adamwight
Copy link
Contributor Author

Rebased. The other commit conflicted constructively and already renames some usages of the word.

@bjorng bjorng added the testing currently being tested, tag is used by OTP internal CI label Feb 27, 2025
@bjorng bjorng merged commit 647d2f0 into erlang:master Feb 28, 2025
27 checks passed
@bjorng
Copy link
Contributor

bjorng commented Feb 28, 2025

Thanks for your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants