Fix Typespecs in zip module #9428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `zip` module has a typespec that is missing the `skip_directories` option in the `unzip` and `list_dir` functions. This commit adds the missing option to the typespec so dialyzer doesn't complain about it.
CT Test Results 2 files 97 suites 1h 10m 6s ⏱️ Results for commit f22d9c3. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
zkayser
approved these changes
Feb 12, 2025
garazdawi
approved these changes
Feb 14, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zipmodule has a typespec that is missing theskip_directoriesoption in theunzip/2andlist_dir/2functions.This commit adds the missing option to the typespec, so dialyzer doesn't complain about it.