Relax invariants checked by erts_add_taint before initialization #9307
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 141 suites 49m 32s ⏱️ Results for commit a14c946. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Debug builds configured with static NIFs are currently not usable since they abort during startup. The abort is caused by a check in erts_add_taint that makes sense once the runtime has started but might not be meaningful before the runtime has been started, notably during static NIF initialization. This change adds an additional check that allows erts_add_taint to proceed when called during runtime initialization. With this check, a debug with static NIFs can complete the startup process.
sverker
force-pushed
the
fix-static-nif-init-assertion-failure
branch
from
96f5cf5 to
a14c946
Compare
sverker
approved these changes
Jan 20, 2025
|
Thanks for the fix. I tweaked the commit and rebased your branch to be mergeable to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug builds configured with static NIFs are currently not usable since they abort during startup. The abort is caused by a check in erts_add_taint that makes sense once the runtime has started but might not be meaningful before the runtime has been started, notably during static NIF initialization.
This change adds an additional check that allows erts_add_taint to proceed when called during runtime initialization. With this check, a debug with static NIFs can complete the startup process.
Resolves #9306