ssh: disable CBC ciphers by default #9277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 29 suites 17m 51s ⏱️ Results for commit c30cadb. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
IngelaAndin
previously approved these changes
Jan 9, 2025
|
@u3s However I think you need to update the documentation too. In ssl we have legacy_spec which I think is nice. |
u3s
force-pushed
the
kuba/ssh/disable_CBC_by_default/OTP-19420
branch
from
148482b to
8e6d09e
Compare
u3s
force-pushed
the
kuba/ssh/disable_CBC_by_default/OTP-19420
branch
from
8e6d09e to
a8dbf4a
Compare
u3s
added
testing
u3s
force-pushed
the
kuba/ssh/disable_CBC_by_default/OTP-19420
branch
from
a8dbf4a to
197e904
Compare
u3s
force-pushed
the
kuba/ssh/disable_CBC_by_default/OTP-19420
branch
from
5f5e477 to
197e904
Compare
IngelaAndin
reviewed
Jan 14, 2025
u3s
force-pushed
the
kuba/ssh/disable_CBC_by_default/OTP-19420
branch
2 times, most recently
from
476ff4b to
e745f81
Compare
u3s
force-pushed
the
kuba/ssh/disable_CBC_by_default/OTP-19420
branch
from
e745f81 to
c30cadb
Compare
IngelaAndin
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.