ssl: Handle user initiated cancelation during handshake #9273
+41
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 1 files 11 suites 4m 5s ⏱️ Results for commit e87069d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
IngelaAndin
force-pushed
the
ingela/ssl/alert-handling-in-hs-when-user-action-causes-termination/OTP-19411
branch
2 times, most recently
from
bcb4c16 to
73d4a81
Compare
dgud
previously approved these changes
Jan 9, 2025
IngelaAndin
added
the
testing
IngelaAndin
force-pushed
the
ingela/ssl/alert-handling-in-hs-when-user-action-causes-termination/OTP-19411
branch
from
73d4a81 to
be567f5
Compare
u3s
previously approved these changes
Jan 14, 2025
IngelaAndin
force-pushed
the
ingela/ssl/alert-handling-in-hs-when-user-action-causes-termination/OTP-19411
branch
3 times, most recently
from
8f468f1 to
a285873
Compare
An initiated handshake should always be closed with an alert, elminate controlled shutdown that does not send alert.
IngelaAndin
force-pushed
the
ingela/ssl/alert-handling-in-hs-when-user-action-causes-termination/OTP-19411
branch
from
a285873 to
e87069d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initiated handshake should always be closed with an alert, elminate controlled shutdown that does not send alert.