Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl: Remove unnecessary code generalization #9170

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

IngelaAndin
Copy link
Contributor

@IngelaAndin IngelaAndin commented Dec 10, 2024

Removal of some code that is too generalizing making unnecessary module jumping so the code becomes harder to follow.

@IngelaAndin IngelaAndin requested review from u3s and dgud and removed request for u3s December 10, 2024 10:32
@IngelaAndin IngelaAndin self-assigned this Dec 10, 2024
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

CT Test Results

  1 files   11 suites   4m 6s ⏱️
 93 tests  91 ✅ 2 💤 0 ❌
109 runs  107 ✅ 2 💤 0 ❌

Results for commit 0c8a367.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Dec 10, 2024
@IngelaAndin IngelaAndin requested a review from u3s December 10, 2024 12:55
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/refactor-start-up branch 2 times, most recently from f30b7a4 to d8de66f Compare December 11, 2024 11:39
u3s
u3s previously approved these changes Dec 12, 2024
dgud
dgud previously approved these changes Dec 13, 2024
@IngelaAndin IngelaAndin dismissed stale reviews from dgud and u3s via b820f73 December 13, 2024 13:35
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/refactor-start-up branch from d8de66f to b820f73 Compare December 13, 2024 13:35
@IngelaAndin IngelaAndin force-pushed the ingela/ssl/refactor-start-up branch from b820f73 to 0c8a367 Compare December 13, 2024 14:40
@IngelaAndin IngelaAndin merged commit 6b62e3c into erlang:master Dec 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants