Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old style type tests #9138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

richcarl
Copy link
Contributor

@richcarl richcarl commented Dec 3, 2024

The "old style" type tests such as integer(N) (instead of the newer is_integer(N)) have been deprecated for a very long time. I think that they should be dropped from the language.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

CT Test Results

  2 files   11 suites   4m 5s ⏱️
 93 tests  91 ✅ 2 💤 0 ❌
109 runs  107 ✅ 2 💤 0 ❌

Results for commit a15da07.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@rickard-green rickard-green added the team:LG Assigned to OTP language group label Dec 9, 2024
@bjorng
Copy link
Contributor

bjorng commented Dec 11, 2024

I am pretty sure that not everyone in the OTP team thinks that we should remove old language features.

What we perhaps could do is to make it an error to use them by default. Then there could be a nowarn_ancient option to turn off the warnings for all ancient but not recommended language features. That option could also apply to your other suggested removals.

@richcarl
Copy link
Contributor Author

That can of course be done, but it won't reduce the maintenance burden (even if it is small in some cases, it can be big in others). Like Joe used to say: if you add things to a language, you should also remove things now and then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:LG Assigned to OTP language group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants