Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Fix optimization for binary_to_atom and tests #9122

Conversation

lucioleKi
Copy link
Contributor

This is a fix for PR-9042. binary_to_atom/1 and binary_to_existing_atom/1 now use the correct optimization. Tests for SSA in non_throwing_bifs.erl are fixed and added to the correct suite.

This is a fix for [PR-9042](erlang#9042).
`binary_to_atom/1` and `binary_to_existing_atom/1` now use the correct
optimization. Tests for SSA in `non_throwing_bifs.erl` are fixed and
added to the correct suite.
@lucioleKi lucioleKi added the team:VM Assigned to OTP team VM label Nov 27, 2024
@lucioleKi lucioleKi requested a review from bjorng November 27, 2024 14:04
@lucioleKi lucioleKi self-assigned this Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

CT Test Results

    2 files    332 suites   9m 17s ⏱️
  834 tests   832 ✅ 2 💤 0 ❌
5 581 runs  5 579 ✅ 2 💤 0 ❌

Results for commit 7e2e56d.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@lucioleKi lucioleKi requested a review from jhogberg November 27, 2024 14:07
@lucioleKi lucioleKi added the testing currently being tested, tag is used by OTP internal CI label Nov 27, 2024
Copy link
Contributor

@frej frej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SSA-checks look good to me.

@lucioleKi lucioleKi merged commit 44cbbea into erlang:master Nov 28, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants