-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/odbc: use iodbc when available #9083
Conversation
CT Test Results 2 files 15 suites 6m 12s ⏱️ Results for commit bef3a2e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
I think this sounds like desirable, and I asked for some input from other team-member that have to deal with configure more often than me. So hopefully they will have time to look sometime "soonish", however it is not a high priority compared to other things. |
@catap I got some more input, and could you please remove the updated of the generated file configure, this should be updated by us when building. You should only change configure.ac Otherwise it is looking good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not update the generated file as I commented in main PR thread.
iodbc has the same API and it migth be tricky to install both iodbc and unixodbc on the same machine. Let allow to build erlang with iodbc as well.
@IngelaAndin here a rebased to the last master version which keeps only changes in |
Thank you for the PR merged for OTP-28 |
iodbc has the same API and it migth be tricky to install both iodbc and unixodbc on the same machine.
Let allow to build erlang with iodbc as well.