Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/odbc: use iodbc when available #9083

Merged
merged 2 commits into from
Jan 29, 2025
Merged

lib/odbc: use iodbc when available #9083

merged 2 commits into from
Jan 29, 2025

Conversation

catap
Copy link
Contributor

@catap catap commented Nov 18, 2024

iodbc has the same API and it migth be tricky to install both iodbc and unixodbc on the same machine.

Let allow to build erlang with iodbc as well.

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

CT Test Results

  2 files   15 suites   6m 12s ⏱️
201 tests 182 ✅ 19 💤 0 ❌
217 runs  198 ✅ 19 💤 0 ❌

Results for commit bef3a2e.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Nov 25, 2024
@IngelaAndin IngelaAndin self-assigned this Nov 26, 2024
@IngelaAndin
Copy link
Contributor

I think this sounds like desirable, and I asked for some input from other team-member that have to deal with configure more often than me. So hopefully they will have time to look sometime "soonish", however it is not a high priority compared to other things.

@IngelaAndin
Copy link
Contributor

IngelaAndin commented Jan 27, 2025

@catap I got some more input, and could you please remove the updated of the generated file configure, this should be updated by us when building. You should only change configure.ac Otherwise it is looking good.

Copy link
Contributor

@IngelaAndin IngelaAndin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not update the generated file as I commented in main PR thread.

catap added 2 commits January 27, 2025 16:47
iodbc has the same API and it migth be tricky to install both iodbc and
unixodbc on the same machine.

Let allow to build erlang with iodbc as well.
@catap
Copy link
Contributor Author

catap commented Jan 27, 2025

@IngelaAndin here a rebased to the last master version which keeps only changes in configure.ac

@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Jan 28, 2025
@IngelaAndin IngelaAndin merged commit 7fe79a1 into erlang:master Jan 29, 2025
24 checks passed
@IngelaAndin
Copy link
Contributor

Thank you for the PR merged for OTP-28

@catap catap deleted the iodbc branch January 29, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants