Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl: Document TLS alerts in ssl_error messages #9067

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

essen
Copy link
Contributor

@essen essen commented Nov 15, 2024

Small improvement discussed in #9051

Copy link
Contributor

github-actions bot commented Nov 15, 2024

CT Test Results

    2 files     66 suites   47m 30s ⏱️
  800 tests   755 ✅  45 💤 0 ❌
3 778 runs  2 983 ✅ 795 💤 0 ❌

Results for commit 253a7e6.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Nov 16, 2024
@IngelaAndin IngelaAndin self-requested a review November 18, 2024 07:36
IngelaAndin
IngelaAndin previously approved these changes Nov 18, 2024
@IngelaAndin IngelaAndin self-assigned this Nov 18, 2024
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Nov 18, 2024
@IngelaAndin
Copy link
Contributor

@essen It is ready for merge, I think it could be target for maint to improve the docs earlier that OTP-28.

@essen essen changed the base branch from master to maint November 19, 2024 09:32
@essen essen dismissed IngelaAndin’s stale review November 19, 2024 09:32

The base branch was changed.

@essen
Copy link
Contributor Author

essen commented Nov 19, 2024

OK I will rebase.

@essen essen force-pushed the ssl-document-tls-alerts-in-messages branch from 932d571 to 253a7e6 Compare November 19, 2024 09:36
@essen
Copy link
Contributor Author

essen commented Nov 19, 2024

Done.

@IngelaAndin IngelaAndin merged commit 83def86 into erlang:maint Nov 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants