bif_SUITE: Fix failing test cases when run in a git repo #9041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorng
added
team:VM
CT Test Results 3 files 141 suites 49m 42s ⏱️ Results for commit a22c378. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
reviewed
Nov 11, 2024
The preloaded BEAM files in `$ERL_TOP/erts/preloaded/ebin` in the git repo longer contains debug information, causing three test cases to fail. However, BEAM files with debug information can be found in `$ERL_TOP/erts/ebin`. Make sure that the test cases that need debug information pick up the correct BEAM files.
bjorng
force-pushed
the
bjorn/emulator/bif_SUITE
branch
from
1be501f to
a22c378
Compare
garazdawi
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preloaded BEAM files in
$ERL_TOP/erts/preloaded/ebinin the git repo longer contains debug information, causing three test cases to fail. However, BEAM files with debug information can be found in$ERL_TOP/erts/ebin.Make sure that the test cases that need debug information pick up the correct BEAM files.
The preloaded BEAM files in$ERL_TOP/erts/preloaded/ebinin the git repo longer contains debug information. That would cause three of the test cases to fail. Instead of failing, don't attempt to verify BIFs residing in preloaded modules when running the tests in a git repo.