compiler: remove NomatchGuard from strict generators #9025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NomatchGuard` was only needed for strict binary generators to test for non-empty binaries. Now `TailPat` for strict binary generators is changed to an empty binary, and `TailClause` is moved before `NomatchClause` for this case. There is no need to have NomatchGuard anymore.
lucioleKi
added
team:VM
CT Test Results 2 files 323 suites 9m 4s ⏱️ Results for commit 5e5d83c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
bjorng
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NomatchGuardwas only needed for strict binary generators to test for non-empty binaries. NowTailPatfor strict binary generators is changed to an empty binary, andTailClauseis moved beforeNomatchClausefor this case. There is no need to have NomatchGuard anymore.