-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter to specify documentation width in the shell #8651
Add parameter to specify documentation width in the shell #8651
Conversation
CT Test Results 3 files 154 suites 1h 34m 1s ⏱️ For more details on these failures, see this check. Results for commit f8a6528. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Hello! Thanks for the PR and I agree that this would be nice to have. However, it needs a testcase in |
7db2448
to
c28b60e
Compare
Test case and documentation are added. Parameter description is added in Test case and documentation are also added for @garazdawi, please take a look again. |
Great! I realize now that I was very unclear in my comment. The configuration option should be moved to the stdlib application as that is where most of the shell configuration is located. We cannot move the things that are in kernel for backward compatability reasons, but we want all new options to be in stdlib. |
It may be hard to read the documentation rendered over the whole width of the screen. The stdlib configuration parameter is added to override this default behavior.
c28b60e
to
f8a6528
Compare
Got it! Moved the new parameter to stdlib. Please take a look again :) |
Maybe for Erlang/OTP 28 I'll have to do something about the location of these parameters... the current status is a mess... Your changes look good. I'll put it into testing and see if anything unexpected pops up. |
Thanks! |
It may be hard to read the documentation rendered over the whole width of the screen. The kernel configuration parameter is added to override this default behavior.