Crash dump viewer: ignore allocator type from blocks size keys #8532
Conversation
CT Test Results 2 files 15 suites 14m 44s ⏱️ Results for commit a5bdb2d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Thanks for the pull request. I found two problems:
I've pushed a fixup commit with a suggestion for how to fix both of these problems. Can you check that my changes make sense and if so, please squash the commits. I also changed the base to |
gomoripeti
force-pushed
the
crashdump_viewer_allocators
branch
from
444d868 to
4a9143b
Compare
|
Those problems you mention are quite fundamental for a PR :) thanks for addressing them. squashed and rebased. (I have no excuse for the test case, but I thought I used something like the patch for viewing crash dumps back in May) |
|
Thanks! Added to our daily builds. |
|
There were some failures in our daily builds. I've pushed a fixup commit to eliminate those failures. If you again squash the commits, this PR is ready to be merged. |
When gathering info about the allocators (particularly the summaries), crashdump viewer filters "interesting allocator info". However recent crash dumps also contain allocator type in the key so for example "mbcs blocks[sys_alloc] size" did not match the expected "mbcs blocks size". This resulted in "blocks size" always showing "N/A" on the "Allocator Summary" page. This commit removes the part in square brackets when summing blocks size values for each allocator type. Also the first column is made wider to fit the longer keys on the per allocator instance pages.
gomoripeti
force-pushed
the
crashdump_viewer_allocators
branch
from
78fefcf to
a5bdb2d
Compare
|
thank you very much, I squashed and rebased. |
When gathering info about the allocators (particularly the summaries), crashdump viewer filters "interesting allocator info". However recent crash dumps also contain allocator type in the key so for example "mbcs blocks[sys_alloc] size" did not match the expected "mbcs blocks size". This resulted in "blocks size" always showing "N/A" on the "Allocator Summary" page. This commit removes the part in square brackets when summing blocks size values for each allocator type.
Also the first column is made wider to fit the longer keys on the per allocator instance pages.
This PR can be considered just a bug report. My solution here is just a random quick fix and there might be a better one.