public_key: Fix hotsname comparison bug #8023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 16 suites 6m 21s ⏱️ Results for commit 1cb18a9. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
IngelaAndin
force-pushed
the
ingela/public_key/verify_hostname/GH-8021/OTP-18935
branch
from
5180970 to
de42fb7
Compare
u3s
reviewed
Jan 17, 2024
dgud
approved these changes
Jan 17, 2024
u3s
approved these changes
Jan 17, 2024
When certificate CN (common name) contained several dots in a row prefix matches with fewer dots would wrongly match. Closes erlang#8021
IngelaAndin
force-pushed
the
ingela/public_key/verify_hostname/GH-8021/OTP-18935
branch
from
de42fb7 to
1cb18a9
Compare
IngelaAndin
added
the
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8021