Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odbc: Add missing API specs #8013

Merged

Conversation

IngelaAndin
Copy link
Contributor

@IngelaAndin IngelaAndin commented Jan 11, 2024

Add specs to API functions

@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Jan 11, 2024
Copy link
Contributor

github-actions bot commented Jan 11, 2024

CT Test Results

  2 files   15 suites   6m 27s ⏱️
201 tests 182 ✅ 19 💤 0 ❌
217 runs  198 ✅ 19 💤 0 ❌

Results for commit 1fe33fd.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin force-pushed the ingela/odbc/missing-specs/OTP-18926 branch 2 times, most recently from 5fd4e04 to 79f70d8 Compare January 12, 2024 10:28
@IngelaAndin IngelaAndin self-assigned this Jan 12, 2024
@IngelaAndin IngelaAndin requested a review from dgud January 12, 2024 12:52
Copy link
Contributor

@dgud dgud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except {value()}

@IngelaAndin IngelaAndin force-pushed the ingela/odbc/missing-specs/OTP-18926 branch from 79f70d8 to 1ceab90 Compare January 15, 2024 21:05
@IngelaAndin IngelaAndin force-pushed the ingela/odbc/missing-specs/OTP-18926 branch from 1ceab90 to 1fe33fd Compare January 16, 2024 06:50
@IngelaAndin
Copy link
Contributor Author

@dgud Well it turns out a variable tuple length is hard to express, I made it tuple() and try to explain it the text instead.

@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Jan 16, 2024
@IngelaAndin IngelaAndin merged commit bd63ecf into erlang:maint Jan 16, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants