Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend -init_debug to print module loading commands #8004

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

cflicker
Copy link
Contributor

@cflicker cflicker commented Jan 6, 2024

391ed66 (#6685) added printing of timing for the path setting commands:

{progress,preloaded}
{path,["$ROOT/lib/kernel-9.2/ebin","$ROOT/lib/stdlib-5.2/ebin"]}
{done_in_microseconds,224}
{progress,kernel_load_completed}
{path,["$ROOT/lib/kernel-9.2/ebin"]}
{done_in_microseconds,213}
{path,["$ROOT/lib/stdlib-5.2/ebin"]}
{done_in_microseconds,186}
...

However, since module loading comprises a significant portion of the boot script time, it would be helpful to include timings for module loading as well.
Therefore, this commit also adds the module loading commands to the -init_debug output:

{progress,preloaded}
{path,["$ROOT/lib/kernel-9.2/ebin","$ROOT/lib/stdlib-5.2/ebin"]}
{done_in_microseconds,447}
{primLoad,[error_handler,application,application_controller,application_master,code,code_server,erl_eval,erl_lint,erl_parse,error_logger,ets,file,filename,file_server,file_io_server,gen,gen_event,gen_server,heart,kernel,logger,logger_filters,logger_server,logger_backend,logger_config,logger_simple_h,lists,proc_lib,supervisor]}
{done_in_microseconds,78379}
{progress,kernel_load_completed}
{path,["$ROOT/lib/kernel-9.2/ebin"]}
{done_in_microseconds,126}
{primLoad,[application_starter,auth,disk_log,disk_log_1,disk_log_server,disk_log_sup,dist_ac,dist_util,erl_boot_server,erl_compile_server,erl_ddll,erl_distribution,erl_epmd,erl_erts_errors,erl_kernel_errors,erl_reply,erl_signal_handler,erpc,erts_debug,gen_sctp,gen_tcp,gen_tcp_socket,gen_udp,gen_udp_socket,global,global_group,global_search,group,group_history,inet,inet6_sctp,inet6_tcp,inet6_tcp_dist,inet6_udp,inet_config,inet_db,inet_dns,inet_epmd_dist,inet_epmd_socket,inet_gethost_native,inet_hosts,inet_parse,inet_res,inet_sctp,inet_tcp,inet_tcp_dist,inet_udp,kernel_config,kernel_refc,local_tcp,local_udp,logger_disk_log_h,logger_formatter,logger_h_common,logger_handler_watcher,logger_olp,logger_proxy,logger_std_h,logger_sup,net,net_adm,net_kernel,os,pg,pg2,prim_tty,ram_file,raw_file_io,raw_file_io_compressed,raw_file_io_deflate,raw_file_io_delayed,raw_file_io_inflate,raw_file_io_list,rpc,seq_trace,socket,standard_error,user_drv,user_sup,wrap_log_reader]}
{done_in_microseconds,87934}
{path,["$ROOT/lib/stdlib-5.2/ebin"]}
{done_in_microseconds,253}
{primLoad,[argparse,array,base64,beam_lib,binary,c,calendar,dets,dets_server,dets_sup,dets_utils,dets_v9,dict,digraph,digraph_utils,edlin,edlin_context,edlin_expand,edlin_key,edlin_type_suggestion,epp,erl_abstract_code,erl_anno,erl_bits,erl_compile,erl_error,erl_expand_records,erl_features,erl_internal,erl_posix_msg,erl_pp,erl_scan,erl_stdlib_errors,erl_tar,error_logger_file_h,error_logger_tty_h,escript,eval_bits,file_sorter,filelib,gb_sets,gb_trees,gen_fsm,gen_statem,io,io_lib,io_lib_format,io_lib_fread,io_lib_pretty,log_mf_h,maps,math,ms_transform,orddict,ordsets,otp_internal,peer,pool,proplists,qlc,qlc_pt,queue,rand,random,re,sets,shell,shell_default,shell_docs,slave,sofs,string,supervisor_bridge,sys,timer,unicode,unicode_util,uri_string,win32reg,zip]}
{done_in_microseconds,137688}
...

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jan 6, 2024

CT Test Results

    3 files    140 suites   45m 57s ⏱️
1 576 tests 1 526 ✅ 50 💤 0 ❌
2 088 runs  2 019 ✅ 69 💤 0 ❌

Results for commit 27d9778.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Jan 8, 2024
@garazdawi garazdawi added the testing currently being tested, tag is used by OTP internal CI label Jan 8, 2024
@garazdawi garazdawi merged commit da0e95e into erlang:master Jan 15, 2024
16 checks passed
@garazdawi
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants