stdlib: Include process label in gen_statem, gen_server, gent_event, gen_fsm crash messages #8003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For gen_statem processes, as well as gen_servers, gen_event and
gen_fsms, if they crash and a process label had been set with
proc_lib:set_label/1, then include that label in the printout,
to make it easier to identify the crashing process.
Below is an example of what it may look like for a gen_statem.
The "Process label" on the second line is new.
** State machine <0.1386.0> terminating
** Process label = {some_label, ...}
** When server state = #{...}
** Reason for termination = error:...
** Callback modules = [...]
** Callback mode = state_functions
If no label has been set, then that process label line will not be
included, and the printout will look like it did before this commit.
CT Test Results 2 files 92 suites 35m 53s ⏱️ For more details on these failures, see this check. Results for commit 17183ba. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
RaimoNiskanen
added
feature
testing
dgud
added
testing
|
Great work! Thank you for your pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #7720 added process labels and the
proc_lib:set_label/1andget_label/1functions. This PR includes a process label printout in crash message printouts from gen_statems, gen_servers, gen_events and gen_fsms, to make it easier to identify the crashing process.Below is an example of what it may look like for a gen_statem. The "Process label" on the second line is new.
If no label has been set, then that process label line will not be included, and the printout will look like it did before this commit.