ct: Introduce replace mode to cth_log_redirect #7891
Conversation
CT Test Results 2 files 58 suites 1h 24m 27s ⏱️ Results for commit 7e6dc24. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
u3s
added
team:PS
| </item> | ||
| <tag><c>{mode, add}</c></tag> | ||
| <item> | ||
| <p>Add the logging handler instead of replacing the default logging |
There was a problem hiding this comment.
Please skip part "instead of replacing the default logging" - I think this would simplify the description.
maybe 2 first sentences could be combined into one ...?
There was a problem hiding this comment.
I've changed the first two sentences to "Add cth_log_redirect to the default logging handler: Logs will be emitted to both standard output via the default handler, and into the Common Test HTML logs.". What do you think?
In addition to the existing way of logging to both the CT HTML logs and console, allow users to completely replace the standard logging handler with the log redirect hook, effectively silencing console logging output during Common Test runs. Mostly taken from erlang#7375, with the caveat that "add" mode continues being the default, and no changes outside of the hook take place. Additionally, group cth_log_redirect test cases together to allow for easier module verification.
jchristgit
force-pushed
the
cth-log-redirect-mode-option
branch
from
1af9a06 to
7e6dc24
Compare
u3s
added
testing
In addition to the existing way of logging to both the CT HTML logs and console, allow users to completely replace the standard logging handler with the log redirect hook, effectively silencing console logging output during Common Test runs.
Mostly taken from #7375, with the caveat that "add" mode continues being the default, and no changes outside of the hook take place.
Additionally, group cth_log_redirect test cases together to allow for easier module verification.
As suggested in #7375 (comment)