Kuba/ssh/simplify connection handler startup #7849
Merged
+129
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
u3s
commented
Nov 9, 2023
u3s
commented
- Simplify ssh_connection_handler init procedure
- so that process does not operate on Socket until it becomes its owner
u3s
force-pushed
the
kuba/ssh/simplify_connection_handler_startup
branch
2 times, most recently
from
42a576e to
e0f494a
Compare
u3s
force-pushed
the
kuba/ssh/simplify_connection_handler_startup
branch
from
e0f494a to
bc2dd04
Compare
u3s
force-pushed
the
kuba/ssh/simplify_connection_handler_startup
branch
from
bc2dd04 to
053623b
Compare
IngelaAndin
requested changes
Nov 13, 2023
u3s
force-pushed
the
kuba/ssh/simplify_connection_handler_startup
branch
from
053623b to
3c4fa52
Compare
IngelaAndin
approved these changes
Nov 17, 2023
- avoid operating on socket in init function - during process init ssh_connection_handler does not owe Socket yet - before that change ssh_connection_handler initialization could fail and result with error reports - above happened if socket creator/original owner exited, Socket became unusable and ssh_connection_handler tried to work with Socket in init - this commit postpones Socket use until connection handler becomes - Socket owner
u3s
force-pushed
the
kuba/ssh/simplify_connection_handler_startup
branch
from
3c4fa52 to
b164ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.