Repository navigation
Compiler: Add assertion for violation of argument type invariant - #11746
Merged
Merged
Conversation
bjorng
added
team:VM
Contributor
CT Test Results 2 files 332 suites 7m 52s ⏱️ Results for commit ca20bf8. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Converting the following expression:
case V of
true -> true;
false -> true
end
to:
is_boolean(V)
could result in the loss of type information, causing types to be
widened during the optimization pass of `beam_ssa_type`.
Co-authored-by: Isabell Huang <isabell@erlang.org>
bjorng
force-pushed
the
bjorn/compiler/assertions
branch
from
October 1, 2026 13:04
46889aa to
5c63dfd
Compare
After the signature pass of beam_ssa_type, while doing type-based optimizations, an invariant to be maintained is that argument types are not widened. Abort the compilation if this invariant is violated.
bjorng
force-pushed
the
bjorn/compiler/assertions
branch
2 times, most recently
from
October 5, 2026 12:05
b62ec58 to
ca20bf8
Compare
lucioleKi
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abort the compilation if an expected invariant for argument types is violated.