Let the search list have an implicit final top domain entry #10576
+190
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CT Test Results 2 files 72 suites 1h 6m 21s ⏱️ For more details on these failures, see this check. Results for commit a55e31b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
This is what all OS resolvers we know of does, and it has been on a future improvement list since at least R13B01, in a comment in inet_res.erl. So, when the name to look up has been tried with all domain search list entries, do a final attempt as if the top domain is an invisible last domain search list entry. This only applies to names without a dot (implicit ndots=1), since for names with at least one dot they are tried as absolute names *before* starting with the search list, as before this change.
RaimoNiskanen
force-pushed
the
raimo/kernel/inet_res-final-absolute/OTP-19937
branch
from
23b9147 to
2230292
Compare
RaimoNiskanen
added
team:PS
RaimoNiskanen
force-pushed
the
raimo/kernel/inet_res-final-absolute/OTP-19937
branch
from
db92d1e to
bfa8bae
Compare
RaimoNiskanen
force-pushed
the
raimo/kernel/inet_res-final-absolute/OTP-19937
branch
from
bfa8bae to
a55e31b
Compare
Contributor
Author
|
Ready for review. Awaiting, hopefully, comments from issue #10494 reporter..., and from someone with repository write access. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10494.
Make the build in DNS resolver
inet_resdo a final request assuming that the given Name to resolve is an absolute name, by having an implicit top domain entry last in the domain search list.