Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code splitting with require.ensure. #1216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leifdalan
Copy link

  • Used require.ensure to enable code splitting
  • Used example of dispatching load begin and load end redux actions to be able to respond in the parent connect view

@haocse
Copy link

haocse commented Jul 17, 2016

I got this warning, anyone has the solution?

Warning: React attempted to reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server:
(client) <!-- react-empty: 1 -
(server) <div class="app___3sz

@grgur
Copy link

grgur commented Oct 14, 2016

Good work there. I reused your excellent commit and tuned it a little to enable named chunks and fix SSR - CSR issues that @haovn577 mentioned above. PR #1298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants